remove duplicated deps and add required deps#7727
Conversation
|
Removing the duplicates makes sense, but why should we install the additional libs? Are there any tests skipped on Azure Pipelines without? It doesn't look like that. |
|
@cmb69 not sure if they cause a skipped tests on Azure, I just got some errors on the |
|
I haven't thoroughly checked, but I assume these packages are preinstalled on the Azure VMs; that does not imply that they are preinstalled everywhere else, but these scripts are neither documentation nor examples, but rather setup scripts for CI. |
|
@cmb69 yes I know, these deps can be omitted after all. |
|
Well, the scenario was to use the Azure build script to build PHP with the same configs to be able to reproduce the error which was happening in Azure but was not producible on my local machine. so I used this script and I get these errors. |
I see your point, but there is no guarantee that this would allow you to reproduce these issue. @krakjoe, since you originally set up Azure Pipelines CI, what do you think about this PR (especially installing the apparently not strictly needed libraries). |
Actually, this fixed my missed building configs and I was able to reproduce the error that was not reproducible with my previous setup |
|
Okay, then let's go with this. Thanks for the PR! |
there are some duplicated deps and
libjpeg-devandlibjpng-devraised an errors on my machine when I was using this script to compile the src code